Separate and test URI resolving #207
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mielvds
force-pushed
the
split-and-test-iri-resolving
branch
2 times, most recently
from
24b1ce6 to
65201a2
Compare
mielvds
force-pushed
the
split-and-test-iri-resolving
branch
from
65201a2 to
fbe2bcf
Compare
anatoly-scherbakov
approved these changes
Dec 4, 2025
davidlehn
approved these changes
Dec 5, 2025
Member
davidlehn
left a comment
davidlehn
left a comment
There was a problem hiding this comment.
- In jsonld.js I think there was a similar move to a
url.jsfile. Someday I want to see if the jsURLapi can replace a lot of this. Not sure if there's a similar library for python or what considerations there are using such a thing. - I think at some point it may have been decided not to put too many URL related tests in the main test suite. There are some. Perhaps at some point later we could extract these tests out into something shareable between implementations.
Member
I now see the next related PR has a move to a more standard library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves functionality from
context_resolver.pytoiri_resolver.pyso it can be maintained and tested separately.This includes:
resolve()function and adding unittestsremove_dot_segments()and adding unittestsThis work is inspired by https://github.com/rubensworks/relative-to-absolute-iri.js (which is used in https://github.com/rubensworks/jsonld-streaming-parser.js) and can be considered a JS to Python port. The unittests are also ported from that repo as they battle-test both functions.
This PR is work in progress and currently uses pytest for convenience (this might change later).